chore: [Orchestration] reduce exception types #543
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
CharlesDuboisSAP
left a comment
CharlesDuboisSAP
left a comment
There was a problem hiding this comment.
I prefer this to the alternative. I also like what we have currently.
rpanackal
reviewed
Aug 28, 2025
Member
There was a problem hiding this comment.
(Major)
I don't see how the user can tell whether its the input or output filter that failed.
try {
response = client.chatCompletion(prompt, configWithIOFilter)
content = response.getContent();
} catch (OrchestrationClientException e) {
// ...
}I would expect something like isInputFilterException() or the like.. so the user would know which methods to call afterwards.
Currently, the user would have to try-catch the call to chatCompletion() and getContent() separately.
rpanackal
reviewed
Aug 28, 2025
Member
rpanackal
left a comment
rpanackal
left a comment
There was a problem hiding this comment.
Overall, I agree with Charles that this approach is preferred over the one in chore: Improve exception accessors.
Contributor
Author
|
i'm also okay with current state in main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Related
Instead of making the API more strict by adding exception types for different error cases, we can also reduce it to just one.
Feature scope:
ClientException OrchestrationClientException - OrchestrationFilterException - Input - OutputDefinition of Done
Aligned changes with the JavaScript SDKDocumentation updatedRelease notes updated